Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs workflow and configuration updates from the mrz1836/go-broadcast repository (commit 1299e85) to BitcoinSchema/go-bitcoin. The changes primarily update tool versions and enhance coverage reporting capabilities by including raw coverage data files in artifacts.
Changes:
- Updated three tool versions: GOVULNCHECK (1.25.6→1.25.7), GO_COVERAGE (v1.1.17→v1.2.0), and MAGE_X (v1.18.7→v1.19.2)
- Added raw
coverage.outfile to coverage artifacts for both main and branch-specific outputs - Added coverage threshold enforcement step to fail builds when coverage drops below configured thresholds
- Optimized base64 decoding in completion workflow to avoid redundant decode operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/.env.base |
Updates versions for govulncheck, go-coverage, and mage-x tools |
.github/workflows/fortress.yml |
Updates repository comment reference (has issue - points to wrong repo) |
.github/workflows/fortress-coverage.yml |
Adds coverage.out file copying, threshold enforcement step, and includes coverage.out in all file lists |
.github/workflows/fortress-completion-finalize.yml |
Refactors base64 decoding to use intermediate variable for performance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
GOVULNCHECK_GO_VERSIONfrom1.25.6to1.25.7in.github/.env.baseGO_COVERAGE_VERSIONfromv1.1.17tov1.2.0in.github/.env.baseMAGE_X_VERSIONfromv1.18.7tov1.19.2in.github/.env.basecoverage.outfile to output directories in both main and branch-specific coverage processing steps infortress-coverage.ymlWhy It Was Necessary
coverage.outfile needs to be included in coverage artifacts for downstream consumption and debuggingTesting Performed
Impact / Risk