Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the fortress-completion-finalize reusable workflow to safely parse and export workflow inputs and timing data that may contain multiline or complex values.
Changes:
- Switches
jqparsing forALL_INPUTSandTIMING_DATAfrom simplekey=valuestrings to base64-encoded entries viajq -r 'to_entries | .[] | @base64'. - Adds per-entry base64 decoding and uses GitHub Actions heredoc syntax to write
INPUT_*andTIMING_*environment variables, enabling safe handling of multiline values. - Preserves existing key normalization (hyphens to underscores) so downstream consumers of
INPUT_*andTIMING_*variables remain compatible.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/workflows/fortress-completion-finalize.ymlto use base64 encoding and heredoc syntax instead of simple key-value assignmentjq -r 'to_entries | .[] | "\(.key)=\(.value)"'tojq -r 'to_entries | .[] | @base64'for bothALL_INPUTSandTIMING_DATAparsingecho "INPUT_$normalized_key=$value" >> $GITHUB_ENV) with heredoc delimiters (EOF_INPUT_$normalized_keyandEOF_TIMING_$normalized_key)$GITHUB_ENVWhy It Was Necessary
key=valueassignment breaks when values contain newlines or special charactersTesting Performed
env-json) are correctly parsed and stored in environment variablesINPUT_*andTIMING_*prefixesImpact / Risk