Skip to content

[Sync] Update project files from source repository (a5a62a3)#267

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260130-112238-a5a62a3
Jan 30, 2026
Merged

[Sync] Update project files from source repository (a5a62a3)#267
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260130-112238-a5a62a3

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Jan 30, 2026

What Changed

  • Modified the environment variable key normalization in the "Parse Workflow Inputs" step to convert hyphens to underscores using tr '-' '_'
  • Updated all environment variable references throughout the workflow from hyphenated format (e.g., INPUT_setup-result) to underscore format (e.g., INPUT_setup_result)
  • Added a comment explaining the normalization: "Note: Replace hyphens with underscores in keys for GitHub Actions expression compatibility"
  • Applied the normalization to both ALL_INPUTS and TIMING_DATA parsing loops, affecting variables prefixed with INPUT_ and TIMING_

Why It Was Necessary

  • GitHub Actions expressions do not support hyphens in environment variable names, causing potential reference failures
  • Standardizing on underscore-separated variable names ensures compatibility with GitHub Actions expression syntax
  • Prevents runtime errors when accessing environment variables containing workflow results and timing data

Testing Performed

  • Verify workflow runs successfully with the normalized environment variable names
  • Confirm all job status checks properly evaluate using the underscore format (setup_result, test_magex_result, pre_commit_result, etc.)
  • Validate that timing data and input parsing correctly populate environment variables with normalized keys

Impact / Risk

  • Breaking Change: None - this is an internal implementation change within the workflow
  • Risk: Low - affects only environment variable naming convention within this workflow file
  • Compatibility: Improves GitHub Actions expression compatibility and prevents potential variable reference errors

Copilot AI review requested due to automatic review settings January 30, 2026 16:22
@mrz1836 mrz1836 self-assigned this Jan 30, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 30, 2026
@github-actions github-actions bot added the size/M Medium change (51–200 lines) label Jan 30, 2026
@github-actions github-actions bot added the update General updates label Jan 30, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GoFortress completion-finalize reusable workflow to normalize workflow input keys into GitHub Actions–compatible environment variable names.

Changes:

  • Normalize parsed ALL_INPUTS and TIMING_DATA keys by converting hyphens to underscores before exporting to $GITHUB_ENV.
  • Update all downstream ${{ env.INPUT_* }} references to use underscore-based names.
  • Adjust the rendered status banner formatting in the generated report (now using GitHub markdown admonitions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit e7c0025 into master Jan 30, 2026
53 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20260130-112238-a5a62a3 branch January 30, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/M Medium change (51–200 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants