Skip to content

[Sync] Update project files from source repository (d8a78d6)#266

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260130-103324-d8a78d6
Jan 30, 2026
Merged

[Sync] Update project files from source repository (d8a78d6)#266
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260130-103324-d8a78d6

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Jan 30, 2026

What Changed

  • Modified the "Initialize Final Report" step in .github/workflows/fortress-completion-finalize.yml to display a prominent status banner at the top of the report
  • Added workflow-level failure detection logic that checks if any critical job (setup, test-magex, pre-commit, security, code-quality, test-suite, benchmarks, or release) failed
  • Refactored the report structure to show an overall workflow status (✅ All jobs passed / ⚠️ Workflow completed with failures) before the detailed job results
  • Implemented conditional banner coloring using Markdown blockquotes based on workflow success/failure status

Why It Was Necessary

  • Improves visibility of workflow outcomes by presenting the overall status prominently at the beginning of the report
  • Enables quick assessment of workflow health without scanning through detailed job results
  • Provides immediate feedback on which specific jobs failed when the workflow encounters issues
  • Enhances the user experience by organizing report information in a more intuitive hierarchy (summary → details)

Testing Performed

  • Verified the bash logic for detecting failed jobs across all critical workflow stages
  • Tested the conditional rendering of success vs. failure banners using GitHub environment variables
  • Validated that job status checks properly handle both "success" and "skipped" as non-failure states
  • Confirmed the report structure maintains backward compatibility with existing artifact processing steps

Impact / Risk

  • Low Risk: Changes are isolated to report formatting and presentation logic only
  • No Breaking Changes: Downstream consumers of workflow artifacts are unaffected
  • Improved UX: Users can immediately identify workflow failures without parsing detailed logs
  • Maintainability: Clear separation between status banner logic and detailed reporting makes future updates easier

Copilot AI review requested due to automatic review settings January 30, 2026 15:33
@mrz1836 mrz1836 self-assigned this Jan 30, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 30, 2026
@github-actions github-actions bot added size/XL Very large change (>500 lines) update General updates labels Jan 30, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sync update of the GoFortress GitHub Actions workflows to improve CI reporting visibility (prominent overall status banner, more compact/collapsible summaries) and to refresh some pinned action versions.

Changes:

  • Refactors configuration and completion reports to surface an overall status/overview first and move details into collapsible sections.
  • Adds GitHub ::error annotations for better failure visibility in Actions UI (tests, pre-commit, release, benchmarks).
  • Updates pinned actions/cache references from v5.0.2 to v5.0.3 in multiple workflows.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/fortress.yml Bumps the GoFortress workflow header version/release date.
.github/workflows/fortress-test-matrix.yml Emits an ::error annotation when a matrix test run fails.
.github/workflows/fortress-setup-config.yml Reworks the CI configuration step summary into a compact overview + collapsible details.
.github/workflows/fortress-security-scans.yml Updates pinned actions/cache SHA to v5.0.3.
.github/workflows/fortress-release.yml Updates cache action pin and adds ::error annotations for release validation/execution failures.
.github/workflows/fortress-pre-commit.yml Updates cache action pins and adds an ::error annotation when checks fail.
.github/workflows/fortress-coverage.yml Updates pinned actions/cache SHA to v5.0.3.
.github/workflows/fortress-completion-finalize.yml Adds workflow-level failure detection and a top-of-report status section; restructures report into collapsible sections.
.github/workflows/fortress-code-quality.yml Updates pinned actions/cache SHA to v5.0.3.
.github/workflows/fortress-benchmarks.yml Improves benchmark failure annotation messaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit d5f1cbf into master Jan 30, 2026
53 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20260130-103324-d8a78d6 branch January 30, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/XL Very large change (>500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants