Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes workflow configuration files from the source repository (mrz1836/go-broadcast) to remove the workflow cancellation feature that was causing visibility issues with failed jobs. The changes disable automatic workflow cancellation when jobs fail, as the GitHub API was overwriting "failed" status with "cancelled" status, making it impossible to identify which jobs actually failed.
Changes:
- Removed
actions: writepermissions from 7 workflow files and changed toactions: readwhere needed - Removed all workflow cancellation steps that used the
cancel-workflow-on-failureaction - Refactored the results summary in fortress.yml to use bash functions for better maintainability
- Added documentation to the cancel-workflow-on-failure action explaining why it's not in use
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/fortress.yml |
Changed test-suite permissions from actions: write to actions: read; refactored results summary with bash helper functions for cleaner status display |
.github/workflows/fortress-test-suite.yml |
Removed actions: write permissions from test-matrix and fuzz-tests jobs |
.github/workflows/fortress-test-matrix.yml |
Removed actions: write permission and workflow cancellation step from test job |
.github/workflows/fortress-test-fuzz.yml |
Removed actions: write permission and workflow cancellation step from fuzz test job |
.github/workflows/fortress-security-scans.yml |
Removed actions: write permissions and workflow cancellation steps from nancy, govulncheck, and gitleaks jobs |
.github/workflows/fortress-pre-commit.yml |
Removed actions: write permission and workflow cancellation step from pre-commit job |
.github/workflows/fortress-code-quality.yml |
Removed actions: write permissions and workflow cancellation steps from go-vet, lint, and format validation jobs |
.github/actions/cancel-workflow-on-failure/action.yml |
Added NOTE documentation explaining why the action is disabled and kept for potential future use |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Directory Synchronization Details
The following directories were synchronized:
.github/ISSUE_TEMPLATE→.github/ISSUE_TEMPLATE.github/actions→.github/actions.github/scripts→.github/scripts.github/tech-conventions→.github/tech-conventions.github/workflows→.github/workflows.vscode→.vscodePerformance Metrics
Why It Was Necessary
This synchronization ensures the target repository stays up-to-date with the latest changes from the configured source repository. The sync operation identifies and applies only the necessary file changes while maintaining consistency across repositories.
Testing Performed
Impact / Risk