Conversation
There was a problem hiding this comment.
Pull request overview
This pull request synchronizes project configuration files from the source repository (mrz1836/go-broadcast) to update the MAGE-X version and modify the pre-commit workflow to skip linting checks.
Changes:
- Updated MAGE-X from v1.18.1 to v1.18.6 to incorporate recent bug fixes and improvements
- Added
--skip lintflag to all go-pre-commit execution commands to avoid duplicate linting (linting is handled separately in the fortress-code-quality workflow) - Updated command documentation strings across all three execution modes to accurately reflect the new flag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/.env.base |
Updates MAGE_X_VERSION from v1.18.1 to v1.18.6 |
.github/workflows/fortress-pre-commit.yml |
Adds --skip lint flag to go-pre-commit commands in all three execution modes (all files, changed files, and staged files fallback) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo " • Command: go-pre-commit run --skip lint --all-files" | ||
| echo "" | ||
| CHECKS_OUTPUT=$("${{ env.GO_PRE_COMMIT_BINARY }}" run --all-files 2>&1) || CHECKS_EXIT=$? | ||
| CHECKS_OUTPUT=$("${{ env.GO_PRE_COMMIT_BINARY }}" run --skip lint --all-files 2>&1) || CHECKS_EXIT=$? |
There was a problem hiding this comment.
The --skip lint flag is being added to the go-pre-commit command, but this flag does not appear to be documented in the project's go-pre-commit documentation (.github/tech-conventions/pre-commit.md). The documentation shows using --checks to run specific checks or environment variables like SKIP=lint to skip checks, but no --skip command-line flag.
Please verify that go-pre-commit version v1.5.1 (as configured in .github/.env.base) supports the --skip flag. If this is a newer feature, consider updating the GO_PRE_COMMIT_VERSION or updating the documentation to reflect this flag's availability.
| echo " • Command: go-pre-commit run --files <escaped_file_list>" | ||
| CHECKS_OUTPUT=$("${{ env.GO_PRE_COMMIT_BINARY }}" run --files "$SAFE_FILE_LIST" 2>&1) || CHECKS_EXIT=$? | ||
| echo " • Command: go-pre-commit run --skip lint --files <escaped_file_list>" | ||
| CHECKS_OUTPUT=$("${{ env.GO_PRE_COMMIT_BINARY }}" run --skip lint --files "$SAFE_FILE_LIST" 2>&1) || CHECKS_EXIT=$? |
There was a problem hiding this comment.
The --skip lint flag is being added to the go-pre-commit command, but this flag does not appear to be documented in the project's go-pre-commit documentation (.github/tech-conventions/pre-commit.md). The documentation shows using --checks to run specific checks or environment variables like SKIP=lint to skip checks, but no --skip command-line flag.
Please verify that go-pre-commit version v1.5.1 (as configured in .github/.env.base) supports the --skip flag. If this is a newer feature, consider updating the GO_PRE_COMMIT_VERSION or updating the documentation to reflect this flag's availability.
| echo " • Command: go-pre-commit run --skip lint" | ||
| echo "" | ||
| CHECKS_OUTPUT=$("${{ env.GO_PRE_COMMIT_BINARY }}" run 2>&1) || CHECKS_EXIT=$? | ||
| CHECKS_OUTPUT=$("${{ env.GO_PRE_COMMIT_BINARY }}" run --skip lint 2>&1) || CHECKS_EXIT=$? |
There was a problem hiding this comment.
The --skip lint flag is being added to the go-pre-commit command, but this flag does not appear to be documented in the project's go-pre-commit documentation (.github/tech-conventions/pre-commit.md). The documentation shows using --checks to run specific checks or environment variables like SKIP=lint to skip checks, but no --skip command-line flag.
Please verify that go-pre-commit version v1.5.1 (as configured in .github/.env.base) supports the --skip flag. If this is a newer feature, consider updating the GO_PRE_COMMIT_VERSION or updating the documentation to reflect this flag's availability.
What Changed
MAGE_X_VERSIONfromv1.18.1tov1.18.6in.github/.env.base--skip lintflag to allgo-pre-commit runcommands in the fortress-pre-commit workflow--skip lintparameter in all three execution pathsWhy It Was Necessary
Testing Performed
--skip lintflag across all three modes (all files, changed files, and staged files fallback)Impact / Risk
--skip lintflag is an additive parameter that should be supported by go-pre-commit; linting is assumed to be covered elsewhere in the CI pipeline