Skip to content

[Sync] Update project files from source repository (6223e59)#257

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260120-112939-6223e59
Jan 20, 2026
Merged

[Sync] Update project files from source repository (6223e59)#257
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260120-112939-6223e59

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Jan 20, 2026

What Changed

  • Added new environment variable GO_BROADCAST_AI_FAIL_ON_ERROR with a default value of false to .github/.env.base
  • Added comprehensive comment documentation explaining the error handling behavior: when true, AI failures cause sync to fail with an error showing which API key env var was used; when false (default), AI failures silently fall back to static templates
  • Positioned the new configuration under the existing AI retry settings (GO_BROADCAST_AI_RETRY_INITIAL_DELAY and GO_BROADCAST_AI_RETRY_MAX_DELAY)

Why It Was Necessary

  • Provides operators with control over how AI broadcast failures are handled, allowing them to choose between strict error reporting or graceful degradation
  • Enables debugging of AI integration issues by optionally surfacing which API key environment variable was being used when failures occur
  • Maintains backward compatibility by defaulting to silent fallback behavior while allowing opt-in to stricter error handling

Testing Performed

  • Verify the environment variable is correctly loaded in the application configuration
  • Test that when set to true, AI failures properly surface errors with API key environment variable information
  • Test that when set to false or unset, AI failures gracefully fall back to static templates without raising errors

Impact / Risk

  • Breaking Change: None - new optional configuration with safe default behavior
  • Risk: Low - defaults to existing fallback behavior, only affects error handling when explicitly enabled
  • Developer Experience: Improves debugging capabilities for AI integration issues when operators opt-in to strict error mode

Copilot AI review requested due to automatic review settings January 20, 2026 16:29
@mrz1836 mrz1836 self-assigned this Jan 20, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 20, 2026
@github-actions github-actions bot added size/XS Very small change (≤10 lines) update General updates labels Jan 20, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request syncs a new AI error handling configuration from the source repository (mrz1836/go-broadcast). It adds an environment variable that allows operators to control how AI broadcast failures are handled, with an option to either fail with detailed error information or silently fall back to static templates.

Changes:

  • Added GO_BROADCAST_AI_FAIL_ON_ERROR environment variable with a default value of false
  • Added comprehensive comment documentation explaining the error handling modes
  • Positioned the configuration logically within the AI settings section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit a6de885 into master Jan 20, 2026
53 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20260120-112939-6223e59 branch January 20, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/XS Very small change (≤10 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants