Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes CI/CD infrastructure files from the source repository (mrz1836/go-broadcast), updating tooling versions and enhancing GitHub Actions with improved caching and metrics capabilities.
Key Changes:
- Updated MAGE-X from v1.14.1 to v1.15.5, golangci-lint from v2.7.2 to v2.8.0, and yamlfmt from v0.20.0 to v0.21.0
- Enhanced setup-benchstat action with Go version compatibility checking to skip installation on Go versions < 1.23
- Added enhanced code quality metrics (file sizes, averages, package counts) to statistics reporting
- Fixed coverage file processing bug by adding intermediate grep filter for more accurate file counting
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/.env.base |
Updated version numbers for MAGE-X (v1.15.5), golangci-lint (v2.8.0), and yamlfmt (v0.21.0) tooling dependencies |
.github/actions/setup-benchstat/action.yml |
Added go-version input parameter with version compatibility checking to skip installation on Go < 1.23 |
.github/actions/upload-statistics/action.yml |
Added continue-on-error input parameter to allow workflows to continue when non-critical artifact uploads fail |
.github/workflows/fortress-test-matrix.yml |
Passes matrix go-version to setup-benchstat action for version compatibility checking |
.github/workflows/fortress-coverage.yml |
Fixed FILES_PROCESSED calculation by adding grep filter to ensure only properly formatted coverage lines are counted |
.github/workflows/fortress-completion-statistics.yml |
Enhanced statistics display with new metrics (file sizes, averages, test coverage ratio, package count) from updated MAGE-X |
.github/workflows/dependabot-auto-merge.yml |
Updated dependabot/fetch-metadata action from v2.4.0 to v2.5.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace inefficient make+append pattern with properly pre-allocated slice and copy operation. This eliminates the makezero lint warning and improves performance by avoiding unnecessary allocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
MAGE_X_VERSIONfromv1.14.1tov1.15.5in.github/.env.baseMAGE_X_GOLANGCI_LINT_VERSIONfromv2.7.2tov2.8.0in.github/.env.baseMAGE_X_YAMLFMT_VERSIONfromv0.20.0tov0.21.0in.github/.env.baseGO_PRE_COMMIT_GOLANGCI_LINT_VERSIONfromv2.7.2tov2.8.0in.github/.env.basego-versioninput parameter to.github/actions/setup-benchstat/action.ymlgo-versioninput parameter to.github/actions/upload-statistics/action.ymlgo-version: ${{ matrix.go-version }}to setup-benchstat and upload-statistics actionspermissions: contents: readin.github/workflows/dependabot-auto-merge.ymlWhy It Was Necessary
Testing Performed
Impact / Risk