Skip to content

[Sync] Update project files from source repository (f2978c5)#249

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260104-154357-f2978c5
Jan 4, 2026
Merged

[Sync] Update project files from source repository (f2978c5)#249
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260104-154357-f2978c5

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Jan 4, 2026

What Changed

  • Updated .gitpod.yml comments and echo messages to be more generic (removed project-specific references, changed "go-bitcoin" to generic "development environment")
  • Modified Gitpod init task to run magex lint instead of magex build during initial setup
  • Updated quick start command suggestion from magex lint && magex test to magex format:fix && magex lint && magex test:race
  • Changed magex build description from "Build the project" to "Build the project (binary)" for clarity
  • Updated .github/actions/setup-benchstat/action.yml input descriptions (removed "latest" from version example, changed "windows-latest" to "mac-latest")
  • Fixed FILES_PROCESSED calculation in .github/workflows/fortress-coverage.yml to count unique files by parsing coverage file format correctly (excludes mode line, extracts file paths, sorts and counts unique entries) in two locations (lines 740 and 2466)
  • Updated coverage file format comment from "file.go:line.col,line.col count statements" to "path/file.go:startLine.startCol,endLine.endCol stmtCount hitCount"

Why It Was Necessary

  • The Gitpod configuration contained project-specific references that needed to be made more generic for broader reusability
  • The previous FILES_PROCESSED calculation using wc -l was inaccurate as it counted all lines in the coverage file rather than unique files covered
  • Running linters during init instead of build provides earlier feedback on code quality issues for contributors

Testing Performed

  • Verified the new FILES_PROCESSED calculation correctly parses Go coverage file format (excludes mode line, extracts unique file paths)
  • Tested that the updated Gitpod workflow runs linters before tests during initialization
  • Confirmed the action.yml description changes maintain clarity for users

Impact / Risk

  • Low Risk: Changes are primarily documentation, echo messages, and a bug fix in file counting logic
  • Developer Experience: Gitpod users will see linting results earlier in setup process, providing faster feedback
  • Accuracy: Coverage reporting will now correctly count the number of unique files processed rather than total coverage lines

Copilot AI review requested due to automatic review settings January 4, 2026 20:44
@mrz1836 mrz1836 self-assigned this Jan 4, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 4, 2026
@github-actions github-actions bot added size/S Small change (11–50 lines) update General updates labels Jan 4, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs updates from the source repository (go-broadcast) to make the project files more generic and fix a bug in coverage file counting. The changes focus on removing project-specific references, improving documentation clarity, and correcting the FILES_PROCESSED calculation to count unique files rather than total lines.

Key Changes:

  • Genericized Gitpod configuration by removing "go-bitcoin" references and replacing them with generic "development environment" terminology
  • Changed Gitpod init workflow to run magex lint instead of magex build for earlier feedback on code quality issues
  • Fixed FILES_PROCESSED calculation in coverage workflow to correctly count unique files by parsing the coverage file format (excluding mode line, extracting file paths, and deduplicating)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.gitpod.yml Genericized echo messages and comments, changed init task to run linters before build, updated quick start command to include test:race
.github/workflows/fortress-coverage.yml Fixed FILES_PROCESSED calculation to count unique files instead of total lines (2 locations), updated coverage file format comment for clarity
.github/actions/setup-benchstat/action.yml Updated input description examples (removed "latest" from version example, changed runner OS example from "windows-latest" to "mac-latest")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit 12c8cf9 into master Jan 4, 2026
53 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20260104-154357-f2978c5 branch January 4, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/S Small change (11–50 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants