Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs updates from the source repository (go-broadcast) to make the project files more generic and fix a bug in coverage file counting. The changes focus on removing project-specific references, improving documentation clarity, and correcting the FILES_PROCESSED calculation to count unique files rather than total lines.
Key Changes:
- Genericized Gitpod configuration by removing "go-bitcoin" references and replacing them with generic "development environment" terminology
- Changed Gitpod init workflow to run
magex lintinstead ofmagex buildfor earlier feedback on code quality issues - Fixed FILES_PROCESSED calculation in coverage workflow to correctly count unique files by parsing the coverage file format (excluding mode line, extracting file paths, and deduplicating)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.gitpod.yml |
Genericized echo messages and comments, changed init task to run linters before build, updated quick start command to include test:race |
.github/workflows/fortress-coverage.yml |
Fixed FILES_PROCESSED calculation to count unique files instead of total lines (2 locations), updated coverage file format comment for clarity |
.github/actions/setup-benchstat/action.yml |
Updated input description examples (removed "latest" from version example, changed runner OS example from "windows-latest" to "mac-latest") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.gitpod.ymlcomments and echo messages to be more generic (removed project-specific references, changed "go-bitcoin" to generic "development environment")magex lintinstead ofmagex buildduring initial setupmagex lint && magex testtomagex format:fix && magex lint && magex test:racemagex builddescription from "Build the project" to "Build the project (binary)" for clarity.github/actions/setup-benchstat/action.ymlinput descriptions (removed "latest" from version example, changed "windows-latest" to "mac-latest")FILES_PROCESSEDcalculation in.github/workflows/fortress-coverage.ymlto count unique files by parsing coverage file format correctly (excludes mode line, extracts file paths, sorts and counts unique entries) in two locations (lines 740 and 2466)Why It Was Necessary
FILES_PROCESSEDcalculation usingwc -lwas inaccurate as it counted all lines in the coverage file rather than unique files coveredTesting Performed
FILES_PROCESSEDcalculation correctly parses Go coverage file format (excludes mode line, extracts unique file paths)Impact / Risk