Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes CI/CD workflow files and scripts from the source repository (mrz1836/go-broadcast) to the target repository (BitcoinSchema/go-bitcoin). Despite the description claiming "purely cosmetic formatting updates," the changes include functional improvements to bash loop patterns, error handling, and directory structure detection logic.
Key Changes:
- Refactored file iteration loops from unsafe
for x in $(find ...)to safe null-delimitedwhile IFS= read -r -d '' xpattern in fortress-test-validation.yml and fortress-coverage.yml - Added
|| trueerror suppression to copy_ci_artifact calls in fortress-completion-tests.yml to prevent pipeline failures - Enhanced parse-test-label.sh with explicit directory structure detection and improved warning messages
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/fortress-test-validation.yml |
Refactored 5 file iteration loops to use safe null-delimited pattern for handling filenames with special characters |
.github/workflows/fortress-coverage.yml |
Refactored 1 file iteration loop to use safe null-delimited pattern |
.github/workflows/fortress-completion-tests.yml |
Added error suppression (` |
.github/scripts/parse-test-label.sh |
Enhanced copy_ci_artifact function with explicit directory structure detection and better fallback handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/workflows/fortress-completion-tests.yml,.github/workflows/fortress-coverage.yml,.github/workflows/fortress-test-validation.yml) with whitespace and line ending normalization.github/scripts/parse-test-label.shbash script with consistent formatting and line ending standardizationWhy It Was Necessary
Testing Performed
Impact / Risk