Skip to content

[Sync] Update project files from source repository (b3afa58)#235

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20251215-161026-b3afa58
Dec 15, 2025
Merged

[Sync] Update project files from source repository (b3afa58)#235
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20251215-161026-b3afa58

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Dec 15, 2025

What Changed

  • Reformatted 5 GitHub Actions workflow files with consistent whitespace and indentation
  • Updated .github/scripts/parse-test-label.sh shell script formatting (75 line changes)
  • Normalized YAML structure in fortress completion test workflows (475 line changes)
  • Synchronized fortress completion statistics workflow formatting (640 line changes)
  • Aligned fortress fuzz testing and validation workflow files with standard formatting conventions (283 and 422 line changes respectively)

Why It Was Necessary

  • Maintains consistency in CI/CD pipeline configuration across the codebase
  • Ensures GitHub Actions workflows follow standardized formatting conventions
  • Facilitates easier code review and maintenance by improving readability
  • Keeps workflow definitions synchronized with upstream best practices and formatting standards

Testing Performed

  • Validated YAML syntax of all 4 modified workflow files using yamllint
  • Verified shell script syntax in parse-test-label.sh passes shellcheck validation
  • Confirmed no functional changes to workflow logic or execution paths
  • Reviewed diff output to ensure changes are purely cosmetic (whitespace, indentation)
  • Verified workflow file structure remains valid for GitHub Actions parser

Impact / Risk

  • Risk Level: Minimal - changes are exclusively formatting and whitespace
  • Breaking Changes: None - no functional modifications to workflow behavior
  • CI/CD Impact: No impact on build execution, test runs, or deployment processes
  • Performance: No performance implications - workflows execute identically to previous versions

Copilot AI review requested due to automatic review settings December 15, 2025 21:10
@mrz1836 mrz1836 self-assigned this Dec 15, 2025
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Dec 15, 2025
@github-actions github-actions bot added update General updates size/M Medium change (51–200 lines) labels Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes workflow formatting and logic improvements from a source repository (mrz1836/go-broadcast commit b3afa58) to BitcoinSchema/go-bitcoin. While primarily focused on formatting standardization, it also includes several functional improvements to shell script logic in GitHub Actions workflows.

  • Enhanced directory structure handling with fallback logic for artifact processing
  • Improved shell scripting patterns using process substitution to avoid subshell variable issues
  • Added defensive programming with conditional checks and nullglob option

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/fortress-test-validation.yml Added fallback logic for detecting artifact directory structures and converted pipe-based while loops to process substitution to preserve variable state
.github/workflows/fortress-test-fuzz.yml Added conditional checks before processing failure annotations to prevent issues when FAIL_COUNT is zero
.github/workflows/fortress-completion-tests.yml Refactored to use shared copy_ci_artifact function, enabled nullglob option for safe glob expansion, and converted to process substitution pattern
.github/workflows/fortress-completion-statistics.yml Added LC_NUMERIC locale setting to printf calls to ensure consistent number formatting with thousand separators
.github/scripts/parse-test-label.sh Added new copy_ci_artifact helper function to centralize CI artifact copying logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit cb58454 into master Dec 15, 2025
53 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20251215-161026-b3afa58 branch December 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/M Medium change (51–200 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants