Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes workflow formatting and logic improvements from a source repository (mrz1836/go-broadcast commit b3afa58) to BitcoinSchema/go-bitcoin. While primarily focused on formatting standardization, it also includes several functional improvements to shell script logic in GitHub Actions workflows.
- Enhanced directory structure handling with fallback logic for artifact processing
- Improved shell scripting patterns using process substitution to avoid subshell variable issues
- Added defensive programming with conditional checks and nullglob option
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/fortress-test-validation.yml |
Added fallback logic for detecting artifact directory structures and converted pipe-based while loops to process substitution to preserve variable state |
.github/workflows/fortress-test-fuzz.yml |
Added conditional checks before processing failure annotations to prevent issues when FAIL_COUNT is zero |
.github/workflows/fortress-completion-tests.yml |
Refactored to use shared copy_ci_artifact function, enabled nullglob option for safe glob expansion, and converted to process substitution pattern |
.github/workflows/fortress-completion-statistics.yml |
Added LC_NUMERIC locale setting to printf calls to ensure consistent number formatting with thousand separators |
.github/scripts/parse-test-label.sh |
Added new copy_ci_artifact helper function to centralize CI artifact copying logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/scripts/parse-test-label.shshell script formatting (75 line changes)Why It Was Necessary
Testing Performed
parse-test-label.shpasses shellcheck validationImpact / Risk