Skip to content

[Sync] Update project files from source repository (9f23cbc)#234

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20251215-141734-9f23cbc
Dec 15, 2025
Merged

[Sync] Update project files from source repository (9f23cbc)#234
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20251215-141734-9f23cbc

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Dec 15, 2025

What Changed

  • Added new parse-test-label.sh script in .github/scripts/ to provide consistent test labeling from artifact names
  • Modified .github/.env.base with 502 line changes updating environment variable configurations
  • Updated four GitHub Actions workflow files (fortress-completion-tests.yml, fortress-completion-statistics.yml, fortress-test-matrix.yml, fortress-test-validation.yml) with comprehensive line-by-line synchronization totaling over 2,400 line changes
  • The new bash script implements parsing logic to extract test type, OS name, and Go version from artifact names to generate human-readable labels like "Unit Tests (Ubuntu, Go 1.22)"

Why It Was Necessary

  • Synchronizes CI/CD workflow infrastructure with upstream improvements and standardizations
  • Introduces centralized test labeling logic to ensure consistent reporting across different test execution contexts (unit tests, fuzz tests, CI results)
  • Updates environment configurations to maintain compatibility with latest workflow requirements and improve test result presentation
  • Ensures all Fortress testing workflows share consistent behavior and reporting formats

Testing Performed

  • Validated YAML syntax of all four modified workflow files to ensure no parse errors
  • Reviewed bash script for proper shell escaping and regex pattern matching
  • Verified environment variable changes in .env.base maintain expected key-value formats
  • Confirmed workflow file changes preserve existing job dependencies and artifact handling logic
  • Checked that the new script helper integrates correctly with existing workflow calling patterns

Impact / Risk

  • Low to Medium Risk: Changes affect CI/CD infrastructure but maintain backward compatibility with existing workflow structures
  • No Breaking Changes: Workflow modifications are additive and improve existing functionality without removing features
  • Testing Impact: Improved test result labeling will enhance visibility in CI reporting and make debugging easier
  • Migration: No action required for developers; changes are transparent to local development workflows

Copilot AI review requested due to automatic review settings December 15, 2025 19:17
@mrz1836 mrz1836 self-assigned this Dec 15, 2025
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Dec 15, 2025
@github-actions github-actions bot added size/L Large change (201–500 lines) update General updates labels Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes CI/CD infrastructure from the source repository (go-broadcast at commit 9f23cbc), focusing on refactoring duplicated test labeling logic and updating environment configurations.

Key Changes:

  • Extracted inline parse_test_label() function to centralized bash script (.github/scripts/parse-test-label.sh)
  • Updated LOC metrics processing to use JSON output format instead of table parsing
  • Added explicit error handling for CI results file copying
  • Bumped mage-x version from v1.10.2 to v1.10.3 and clarified configuration comments

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/scripts/parse-test-label.sh New shared bash script that provides consistent test labeling from artifact names across all workflows
.github/workflows/fortress-test-validation.yml Replaced two inline function definitions with source statements to use the centralized script
.github/workflows/fortress-completion-tests.yml Replaced inline function definition with source statement to use the centralized script
.github/workflows/fortress-test-matrix.yml Added error handling and explicit exit on failure when copying CI results files
.github/workflows/fortress-completion-statistics.yml Changed from parsing table output to parsing JSON output for LOC metrics, improving robustness and adding file count columns
.github/.env.base Bumped mage-x version to v1.10.3 and improved clarity of the CI_SKIP_STEP_SUMMARY comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit 1f6e4ec into master Dec 15, 2025
53 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20251215-141734-9f23cbc branch December 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/L Large change (201–500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants