Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes CI/CD infrastructure from the source repository (go-broadcast at commit 9f23cbc), focusing on refactoring duplicated test labeling logic and updating environment configurations.
Key Changes:
- Extracted inline
parse_test_label()function to centralized bash script (.github/scripts/parse-test-label.sh) - Updated LOC metrics processing to use JSON output format instead of table parsing
- Added explicit error handling for CI results file copying
- Bumped mage-x version from v1.10.2 to v1.10.3 and clarified configuration comments
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/scripts/parse-test-label.sh |
New shared bash script that provides consistent test labeling from artifact names across all workflows |
.github/workflows/fortress-test-validation.yml |
Replaced two inline function definitions with source statements to use the centralized script |
.github/workflows/fortress-completion-tests.yml |
Replaced inline function definition with source statement to use the centralized script |
.github/workflows/fortress-test-matrix.yml |
Added error handling and explicit exit on failure when copying CI results files |
.github/workflows/fortress-completion-statistics.yml |
Changed from parsing table output to parsing JSON output for LOC metrics, improving robustness and adding file count columns |
.github/.env.base |
Bumped mage-x version to v1.10.3 and improved clarity of the CI_SKIP_STEP_SUMMARY comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
parse-test-label.shscript in.github/scripts/to provide consistent test labeling from artifact names.github/.env.basewith 502 line changes updating environment variable configurationsfortress-completion-tests.yml,fortress-completion-statistics.yml,fortress-test-matrix.yml,fortress-test-validation.yml) with comprehensive line-by-line synchronization totaling over 2,400 line changesWhy It Was Necessary
Testing Performed
.env.basemaintain expected key-value formatsImpact / Risk