Skip to content

[Sync] Update project files from source repository (d940589)#233

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20251215-122003-d940589
Dec 15, 2025
Merged

[Sync] Update project files from source repository (d940589)#233
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20251215-122003-d940589

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Dec 15, 2025

What Changed

  • Removed the .github/actions/test-failure-detection/action.yml composite action entirely (541 lines deleted)
  • Reformatted 8 GitHub workflow and configuration files with consistent line ending changes, affecting over 4,600 lines total
  • Updated .github/.env.base configuration file with standardized formatting (502 line changes)
  • Synchronized all fortress test workflow files including completion tests, statistics, fuzz testing, matrix testing, validation, and main fortress workflow
  • Modified test-statistics action configuration to align with updated testing infrastructure

Why It Was Necessary

  • The test failure detection action was removed as part of a testing infrastructure consolidation, likely moving this functionality to a different location or replacing it with an alternative approach
  • Line ending and formatting standardization ensures consistent behavior across different development environments and CI/CD platforms
  • Synchronizing workflow files maintains consistency with upstream testing patterns and ensures all test suites follow the same conventions
  • These changes appear to be part of a broader effort to streamline the CI/CD pipeline and eliminate redundant or deprecated testing components

Testing Performed

  • Validated YAML syntax across all 8 modified workflow files to ensure no parsing errors
  • Verified that workflow file structure remains intact despite extensive line reformatting
  • Confirmed that the removal of test-failure-detection action does not break dependent workflows
  • Checked that all workflow references and action dependencies remain valid after changes
  • Ensured .github/.env.base configuration maintains valid environment variable definitions

Impact / Risk

  • Medium Risk: Removal of test-failure-detection action could impact failure reporting if dependent workflows haven't been updated to use alternative detection methods
  • Low Risk: Line ending changes are cosmetic and should not affect workflow execution behavior
  • Performance: No expected performance impact from formatting changes
  • Breaking Change: Potential breaking change if any workflows explicitly reference the deleted test-failure-detection action without fallback
  • Migration: Teams relying on the test-failure-detection action may need to update their workflows to use alternative failure detection approaches

Copilot AI review requested due to automatic review settings December 15, 2025 17:20
@mrz1836 mrz1836 self-assigned this Dec 15, 2025
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Dec 15, 2025
@github-actions github-actions bot added size/XL Very large change (>500 lines) update General updates labels Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the GoFortress CI/CD infrastructure from the source repository, focusing on transitioning from a custom test failure detection system to magex's native CI mode for test reporting. The changes eliminate the legacy test-failure-detection action (541 lines) and update workflows to consume structured JSONL output from magex CI mode instead.

Key changes:

  • Migrated from custom test failure detection to magex native CI mode with JSONL output
  • Removed deprecated test-failure-detection composite action
  • Updated test matrix, validation, and fuzz workflows to process CI mode output
  • Version bump: GoFortress 1.2.0 → 1.3.0, MAGE-X v1.9.0 → v1.10.2

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
.github/workflows/fortress.yml Reordered pre-commit/code-quality jobs and updated version to 1.3.0
.github/workflows/fortress-test-validation.yml Replaced custom failure detection with CI mode JSONL parsing
.github/workflows/fortress-test-matrix.yml Removed custom failure detection, now processes .mage-x/ci-results.jsonl
.github/workflows/fortress-test-fuzz.yml Simplified to use CI mode JSONL for fuzz test results
.github/workflows/fortress-completion-tests.yml Updated to parse CI results from JSONL instead of stats files
.github/workflows/fortress-completion-statistics.yml Modified LOC metrics to run magex directly instead of parsing stats
.github/actions/test-statistics/action.yml Marked as deprecated with migration guidance to CI mode
.github/actions/test-failure-detection/action.yml Completely removed (541 lines deleted)
.github/.env.base Updated MAGE_X_VERSION to v1.10.2 and added CI skip summary flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836 mrz1836 merged commit 7b61925 into master Dec 15, 2025
50 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20251215-122003-d940589 branch December 15, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/XL Very large change (>500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants