Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the GoFortress CI/CD infrastructure from the source repository, focusing on transitioning from a custom test failure detection system to magex's native CI mode for test reporting. The changes eliminate the legacy test-failure-detection action (541 lines) and update workflows to consume structured JSONL output from magex CI mode instead.
Key changes:
- Migrated from custom test failure detection to magex native CI mode with JSONL output
- Removed deprecated test-failure-detection composite action
- Updated test matrix, validation, and fuzz workflows to process CI mode output
- Version bump: GoFortress 1.2.0 → 1.3.0, MAGE-X v1.9.0 → v1.10.2
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/fortress.yml |
Reordered pre-commit/code-quality jobs and updated version to 1.3.0 |
.github/workflows/fortress-test-validation.yml |
Replaced custom failure detection with CI mode JSONL parsing |
.github/workflows/fortress-test-matrix.yml |
Removed custom failure detection, now processes .mage-x/ci-results.jsonl |
.github/workflows/fortress-test-fuzz.yml |
Simplified to use CI mode JSONL for fuzz test results |
.github/workflows/fortress-completion-tests.yml |
Updated to parse CI results from JSONL instead of stats files |
.github/workflows/fortress-completion-statistics.yml |
Modified LOC metrics to run magex directly instead of parsing stats |
.github/actions/test-statistics/action.yml |
Marked as deprecated with migration guidance to CI mode |
.github/actions/test-failure-detection/action.yml |
Completely removed (541 lines deleted) |
.github/.env.base |
Updated MAGE_X_VERSION to v1.10.2 and added CI skip summary flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/actions/test-failure-detection/action.ymlcomposite action entirely (541 lines deleted).github/.env.baseconfiguration file with standardized formatting (502 line changes)test-statisticsaction configuration to align with updated testing infrastructureWhy It Was Necessary
Testing Performed
.github/.env.baseconfiguration maintains valid environment variable definitionsImpact / Risk