Stop prometheus in doctest build.gradle now runs upon project failure in startOpenSearch#276
Merged
MitchellGale merged 2 commits intoInteg/FixPrometheusfrom Jun 15, 2023
Merged
Conversation
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
b178c0f to
6f2e2da
Compare
Codecov Report
@@ Coverage Diff @@
## Integ/FixPrometheus #276 +/- ##
======================================================
Coverage ? 97.41%
Complexity ? 4558
======================================================
Files ? 388
Lines ? 11238
Branches ? 790
======================================================
Hits ? 10947
Misses ? 284
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Yury-Fridlyand
approved these changes
Jun 15, 2023
matthewryanwells
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startOpenSearch is now finalizedBy stopPrometheus allowing stop prometheus to run after crash. This stops a left-over prometheus instance from running after causing future start Prometheus tasks from running.
Steps to reproduce error that is fixed.
Same steps can be taken working from this PR branch and it will not show the error in step 6.
Issues Resolved
1083
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.