Add UTC_DATE, UTC_TIME, UTC_TIMESTAMP#187
Merged
MitchellGale merged 6 commits intoInteg-UTC_DATE_TIME_TIMESTAMP_LIKENOWfrom Dec 19, 2022
Merged
Add UTC_DATE, UTC_TIME, UTC_TIMESTAMP#187MitchellGale merged 6 commits intoInteg-UTC_DATE_TIME_TIMESTAMP_LIKENOWfrom
MitchellGale merged 6 commits intoInteg-UTC_DATE_TIME_TIMESTAMP_LIKENOWfrom
Conversation
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## Integ-UTC_DATE_TIME_TIMESTAMP_LIKENOW #187 +/- ##
============================================================================
- Coverage 98.31% 62.76% -35.55%
============================================================================
Files 348 10 -338
Lines 8707 658 -8049
Branches 555 119 -436
============================================================================
- Hits 8560 413 -8147
- Misses 142 192 +50
- Partials 5 53 +48
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
margarit-h
approved these changes
Dec 10, 2022
Yury-Fridlyand
suggested changes
Dec 10, 2022
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Please, update ppl/src/test/java/org/opensearch/sql/ppl/antlr/NowLikeFunctionParserTest.java and sql/src/test/java/org/opensearch/sql/sql/parser/AstNowLikeFunctionTest.java too
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/sql/DateTimeFunctionIT.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/sql/DateTimeFunctionIT.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/sql/DateTimeFunctionIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Yury-Fridlyand
approved these changes
Dec 11, 2022
acarbonetto
approved these changes
Dec 12, 2022
forestmvey
approved these changes
Dec 13, 2022
GabeFernandez310
approved these changes
Dec 13, 2022
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
MaxKsyunz
approved these changes
Dec 14, 2022
MaxKsyunz
left a comment
There was a problem hiding this comment.
A couple minor style comments but everything else LGTM.
| private DefaultFunctionResolver utc_time() { | ||
| return define(BuiltinFunctionName.UTC_TIME.getName(), | ||
| implWithProperties(functionProperties | ||
| -> DateTimeFunction.exprUtcTime(functionProperties), TIME)); |
There was a problem hiding this comment.
Suggested change
| -> DateTimeFunction.exprUtcTime(functionProperties), TIME)); | |
| ->exprUtcTime(functionProperties), TIME)); |
Doesn't this comment apply here as well?
| private DefaultFunctionResolver utc_timestamp() { | ||
| return define(BuiltinFunctionName.UTC_TIMESTAMP.getName(), | ||
| implWithProperties(functionProperties | ||
| -> DateTimeFunction.exprUtcTimeStamp(functionProperties), DATETIME)); |
There was a problem hiding this comment.
Suggested change
| -> DateTimeFunction.exprUtcTimeStamp(functionProperties), DATETIME)); | |
| ->exprUtcTimeStamp(functionProperties), DATETIME)); |
Doesn't this comment apply here as well?
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality for
UTC_TIME,UTC_DATEandUTC_TIMESTAMPfunctions.UTC_TIME - Returns current UTC time in
HH:mm:sstime format.UTC_DATE - Returns current UTC date in
uuuu-MM-dddate format.UTC_TIMESTAMP - Returns current UTC Date/time in
uuuu-MM-dd HH:mm:ssdate format.Example use cases:
Issues Resolved
opensearch-project#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.