seperated pow tests where results should be null from edge cases

matthewryanwells · matthewryanwells · commit f97e964eb947 · 2023-03-21T09:30:56.000-07:00
Signed-off-by: Matthew Wells &lt;matthew.wells@improving.com&gt;
diff --git a/core/src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java b/core/src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
@@ -1580,7 +1580,18 @@ public void pow_null_output() {
     assertEquals(String.format("pow(%s, %s)", (double) -2, 1.5), pow.toString());
     assertTrue(pow.valueOf(valueEnv()).isNull());
 
-    pow = DSL.pow(DSL.literal((double) -2), DSL.literal((double) 2));
+    pow = DSL.pow(DSL.literal((float) -2), DSL.literal((float) 1.5));
+    assertEquals(pow.type(), DOUBLE);
+    assertEquals(String.format("pow(%s, %s)", (float) -2, (float) 1.5), pow.toString());
+    assertTrue(pow.valueOf(valueEnv()).isNull());
+  }
+
+  /**
+   * Test pow/power with edge cases
+   */
+  @Test
+  public void pow_edge_cases() {
+    FunctionExpression pow = DSL.pow(DSL.literal((double) -2), DSL.literal((double) 2));
     assertEquals(pow.type(), DOUBLE);
     assertEquals(String.format("pow(%s, %s)",(double) -2, (double) 2), pow.toString());
     assertThat(
@@ -1594,11 +1605,6 @@ public void pow_null_output() {
             pow.valueOf(valueEnv()),
             allOf(hasType(DOUBLE), hasValue(Math.pow(2, 1.5))));
 
-    pow = DSL.pow(DSL.literal((float) -2), DSL.literal((float) 1.5));
-    assertEquals(pow.type(), DOUBLE);
-    assertEquals(String.format("pow(%s, %s)", (float) -2, (float) 1.5), pow.toString());
-    assertTrue(pow.valueOf(valueEnv()).isNull());
-
     pow = DSL.pow(DSL.literal((float) -2), DSL.literal((float) 2));
     assertEquals(pow.type(), DOUBLE);
     assertEquals(String.format("pow(%s, %s)", (float) -2, (float) 2), pow.toString());
