Minor cleanup.

Yury-Fridlyand · Yury-Fridlyand · commit 4008c7534f95 · 2022-09-12T17:11:35.000-07:00
Signed-off-by: Yury-Fridlyand &lt;yuryf@bitquilltech.com&gt;
diff --git a/core/src/main/java/org/opensearch/sql/analysis/AnalysisContext.java b/core/src/main/java/org/opensearch/sql/analysis/AnalysisContext.java
@@ -12,7 +12,6 @@
 import java.util.Map;
 import java.util.Objects;
 import lombok.Getter;
-import lombok.Setter;
 import org.opensearch.sql.expression.Expression;
 import org.opensearch.sql.expression.NamedExpression;
 
@@ -33,8 +32,7 @@ public class AnalysisContext {
    * For example, `now` function should the same value during processing a query.
    */
   @Getter
-  @Setter
-  private Map<String, Expression> cachedFunctionValues;
+  private final Map<String, Expression> cachedFunctionValues;
 
   public AnalysisContext() {
     this(new TypeEnvironment(null));
diff --git a/core/src/main/java/org/opensearch/sql/analysis/ExpressionAnalyzer.java b/core/src/main/java/org/opensearch/sql/analysis/ExpressionAnalyzer.java
@@ -173,7 +173,7 @@ public Expression visitRelevanceFieldList(RelevanceFieldList node, AnalysisConte
   @Override
   public Expression visitFunctionWithCachedValue(FunctionWithCachedValue node,
                                                  AnalysisContext context) {
-    var valueName = node.toString();
+    var valueName = node.getFuncName();
     if (context.getCachedFunctionValues().containsKey(valueName)) {
       return context.getCachedFunctionValues().get(valueName);
     }

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ public Expression visitRelevanceFieldList(RelevanceFieldList node, AnalysisConte`
`173`	`173`	`@Override`
`174`	`174`	`public Expression visitFunctionWithCachedValue(FunctionWithCachedValue node,`
`175`	`175`	`AnalysisContext context) {`
`176`		`- var valueName = node.toString();`
	`176`	`+ var valueName = node.getFuncName();`
`177`	`177`	`if (context.getCachedFunctionValues().containsKey(valueName)) {`
`178`	`178`	`return context.getCachedFunctionValues().get(valueName);`
`179`	`179`	`}`