Use pagination in correctess tests too.

Yury-Fridlyand · Yury-Fridlyand · commit 2d33f533ecf0 · 2023-08-14T19:45:29.000-07:00
Signed-off-by: Yury-Fridlyand &lt;yury.fridlyand@improving.com&gt;
diff --git a/integ-test/src/test/java/org/opensearch/sql/correctness/runner/connection/JDBCConnection.java b/integ-test/src/test/java/org/opensearch/sql/correctness/runner/connection/JDBCConnection.java
@@ -118,7 +118,9 @@ public void insert(String tableName, String[] columnNames, List<Object[]> batch)
 
   @Override
   public DBResult select(String query) {
-    try (Statement stmt = connection.createStatement()) {
+    try (Statement stmt =
+        connection.createStatement(ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY)) {
+      stmt.setFetchSize(5);
       ResultSet resultSet = stmt.executeQuery(query);
       DBResult result = isOrderByQuery(query)
           ? DBResult.resultInOrder(databaseName) : DBResult.result(databaseName);
diff --git a/integ-test/src/test/java/org/opensearch/sql/legacy/SQLIntegTestCase.java b/integ-test/src/test/java/org/opensearch/sql/legacy/SQLIntegTestCase.java
@@ -384,7 +384,7 @@ protected static JSONObject updateClusterSettings(ClusterSetting setting, RestCl
     return new JSONObject(executeRequest(request, client));
   }
 
-  protected static JSONObject updateClusterSettings(ClusterSetting setting) throws IOException {
+  public static JSONObject updateClusterSettings(ClusterSetting setting) throws IOException {
     return updateClusterSettings(setting, client());
   }
 
@@ -396,7 +396,7 @@ protected static JSONObject getAllClusterSettings() throws IOException {
     return new JSONObject(executeRequest(request));
   }
 
-  protected static class ClusterSetting {
+  public static class ClusterSetting {
     private final String type;
     private final String name;
     private final String value;
diff --git a/integ-test/src/test/java/org/opensearch/sql/sql/SQLCorrectnessIT.java b/integ-test/src/test/java/org/opensearch/sql/sql/SQLCorrectnessIT.java
@@ -6,13 +6,18 @@
 
 package org.opensearch.sql.sql;
 
+import static org.opensearch.sql.legacy.SQLIntegTestCase.PERSISTENT;
+import static org.opensearch.sql.legacy.SQLIntegTestCase.updateClusterSettings;
+
 import com.google.common.io.Resources;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.function.Function;
 import org.junit.Test;
+import org.opensearch.sql.common.setting.Settings;
+import org.opensearch.sql.legacy.SQLIntegTestCase;
 
 /**
  * SQL integration test automated by comparison test framework.
@@ -26,6 +31,11 @@ public class SQLCorrectnessIT extends CorrectnessTestBase {
   @Override
   protected void init() throws Exception {
     super.init();
+    updateClusterSettings(
+        new SQLIntegTestCase.ClusterSetting(
+            PERSISTENT,
+            Settings.Key.IGNORE_UNSUPPORTED_PAGINATION.getKeyValue(),
+            "true"));
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ protected static JSONObject updateClusterSettings(ClusterSetting setting, RestCl`
`384`	`384`	`return new JSONObject(executeRequest(request, client));`
`385`	`385`	`}`
`386`	`386`
`387`		`- protected static JSONObject updateClusterSettings(ClusterSetting setting) throws IOException {`
	`387`	`+ public static JSONObject updateClusterSettings(ClusterSetting setting) throws IOException {`
`388`	`388`	`return updateClusterSettings(setting, client());`
`389`	`389`	`}`
`390`	`390`
`@@ -396,7 +396,7 @@ protected static JSONObject getAllClusterSettings() throws IOException {`
`396`	`396`	`return new JSONObject(executeRequest(request));`
`397`	`397`	`}`
`398`	`398`
`399`		`- protected static class ClusterSetting {`
	`399`	`+ public static class ClusterSetting {`
`400`	`400`	`private final String type;`
`401`	`401`	`private final String name;`
`402`	`402`	`private final String value;`