Updates for SQLGetDiagFieldW #38

rscales · 2025-05-27T01:01:07Z

Updates for SQLGetDiagFieldW coming from comments to initial merged PR.

Addresses the following issues:

Add statement and descriptor cases now so we don't forget.
Use const std::string& to use copy by reference semantics to avoid copy.
Change to use dsn value retrieved from connection for SQL_DIAG_SERVER_NAME
Allow passing of diagInfoPtr if they just want the length
For GetStringAttribute calls set isLengthInBytes to true for calls with SQLPOINTER and to false for calls with SQLWCHAR
Return dummy values for unimplemented field types

Fixed bug in attribute_utils.h for GetAttributeSQLWCHAR to determine when truncation has been applied.

alinaliBQ · 2025-05-27T01:05:31Z

We can ignore the cancelled check, it was invoked by accident

alinaliBQ

I have went through the code with Rob during our huddle previously, lgtm

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

…elds

…POINTER and to false for calls with SQLWCHAR

cpp/src/arrow/flight/sql/odbc/tests/connection_test.cc

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

…tion

alinaliBQ · 2025-06-02T18:13:53Z

JFYI - I have cancelled the C++ workflows because they were invoked by accident; I had C++ workflows enabled briefly for testing and the sql-get-diag-field-updates branch got pushed at the same time.

alinaliBQ

LGTM

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

Working with Rob for bufferLen = SQL_NTS case

alinaliBQ

LGTM, pls run the Dev workflow for linter

rscales changed the title ~~Update to address changes from code review~~ Updates for SQLGetDiagRecW May 27, 2025

alinaliBQ approved these changes May 27, 2025

View reviewed changes

alinaliBQ changed the title ~~Updates for SQLGetDiagRecW~~ Updates for SQLGetDiagFieldW May 27, 2025

alinaliBQ reviewed May 27, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Outdated Show resolved Hide resolved

rscales force-pushed the sql-get-diag-field-updates branch from af6a96c to f33a81e Compare May 27, 2025 23:49

Update to address changes from code review

e13d61e

rscales force-pushed the sql-get-diag-field-updates branch from f33a81e to e13d61e Compare May 28, 2025 00:14

rscales added 3 commits May 28, 2025 19:16

Change to set isLengthInBytes to false for calls to GetStringAttribute

6249c70

Change to return valid dummy variables for unimplemented fields

7db3799

Add note for unimplemented field types

a3d6c97

rscales marked this pull request as ready for review May 28, 2025 18:24

alinaliBQ reviewed May 28, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Show resolved Hide resolved

jduo reviewed May 28, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Outdated Show resolved Hide resolved

rscales added 5 commits May 28, 2025 23:49

Update to return no row or column number for row and column number fi…

4cf34e4

…elds

For GetStringAttribute set isLengthInBytes to true for calls with SQL…

c1a13bc

…POINTER and to false for calls with SQLWCHAR

Move SQL_DIAG_SERVER_NAME handling to record field switch statement

bc4cd6a

Fix issue with determining if truncation was required

250b6b6

Add test cases for SQLGetDiagField

1724fe6

alinaliBQ reviewed May 30, 2025

View reviewed changes

rscales added 2 commits May 30, 2025 19:37

Run pre-commit to reformat modified files

e8c8c60

Add updates from code review comments

9c2ebdb

jduo reviewed May 30, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Outdated Show resolved Hide resolved

alinaliBQ reviewed Jun 2, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Outdated Show resolved Hide resolved

Move server name determination from DSN to within field retrieval sec…

99e7782

…tion

rscales added 2 commits June 2, 2025 19:17

Update test case assertions based on lint recommendations

9065265

Update with formating changes

120ca96

alinaliBQ previously approved these changes Jun 2, 2025

View reviewed changes

jduo reviewed Jun 2, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Outdated Show resolved Hide resolved

jduo reviewed Jun 2, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Show resolved Hide resolved

jduo reviewed Jun 2, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/odbc_api.cc Show resolved Hide resolved

Update to address diag field header issue and output buffer validation

2de8d02

alinaliBQ reviewed Jun 3, 2025

View reviewed changes

Add note for invalid buffer determination

5dad484

alinaliBQ approved these changes Jun 3, 2025

View reviewed changes

alinaliBQ mentioned this pull request Jun 4, 2025

Enable logging and add new logs #40

Merged

rscales merged this pull request into apache-odbc Jun 4, 2025
6 checks passed

alinaliBQ deleted the sql-get-diag-field-updates branch June 17, 2025 22:11

Updates for SQLGetDiagFieldW #38

Updates for SQLGetDiagFieldW #38

Uh oh!

Conversation

rscales commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alinaliBQ commented May 27, 2025

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alinaliBQ commented Jun 2, 2025

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rscales commented May 27, 2025 •

edited

Loading