Add Coding Plan Authentication#57
Open
BingqingLyu wants to merge 20 commits into
Open
Conversation
… frontend auth sync across sessions
… ensure ui hasContent evaluates to false to allow Onboarding panel render
…on is loaded to prevent old session data from stalling the UI rendering
…ing unscrollable header
…ent flex child overflow
… i18n overlay
This commit achieves the following:
- Redesigns the `Onboarding.tsx` screen to match Claude Code's minimalist structure with better spacing, robust dash borders, and solid styling on primary and secondary buttons.
- Disconnects UI languages from IDE language injection (`vscode.env.language`) in `acpConnection.ts`.
- Strips branch-specific multi-language wrapping (`t()` and `import { t }`) across components like `AskUserQuestionDialog.tsx` and `authMethods.ts`.
- Configures auth method identifiers properly stringified (`coding-plan`) instead of mutating global Enums.
- Fix connection error showing in chat instead of onboarding page - Fix OAuth race condition: keep onboarding visible during re-auth - Align auth method labels with CLI (Select Authentication Method, Free · Up to 1,000 requests/day, API Key / Bring your own API key) - Redesign Coding Plan flow: Region select → API Key (two-step) - Add API key validation (empty check + sk-sp- prefix for China) - Region options: 阿里云百炼 (aliyun.com) / Alibaba Cloud (alibabacloud.com) - Add 'Coding Plan API key here' link per CLI parity - Use Qwen brand purple (#6366f1) for primary buttons - Add outlined secondary buttons and ghost back buttons for better visual hierarchy and button affordance - Center-align all onboarding content Closes QwenLM#2134
…2134-auth-parity
This was referenced Apr 28, 2026
Owner
Author
Conflict Group 1This PR shares modified functions with 2 other PR(s): #114, #96. These PRs should be reviewed as a batch — merging one may affect the others.
graph LR
PR57["PR #57"]
FisInsightCommand_8827["isInsightCommand<br>WebViewProvider.ts"]
PR57 -->|modifies| FisInsightCommand_8827
PR114["PR #114"]
PR114 -->|modifies| FisInsightCommand_8827
PR96["PR #96"]
PR96 -->|modifies| FisInsightCommand_8827
Posted by codegraph-ai conflict detection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces comprehensive authentication enhancements including Alibaba Cloud Coding Plan support and a multi-language internationalization system for the WebUI onboarding experience.
Changes
Core Features
codingPlanLogic.tsutility for handling Coding Plan authentication flow2 Enhanced Onboarding Experience
methodIdand_metaparameter passingModified Files
CLI Package:
packages/cli/src/acp-integration/acpAgent.ts- Added Coding Plan auth handlingpackages/cli/src/acp-integration/authMethods.ts- Updated auth method list with i18npackages/cli/src/utils/codingPlanLogic.ts- New utility for Coding Plan authCore Package:
packages/core/src/core/contentGenerator.ts- Minor updatespackages/core/src/models/constants.ts- Added Coding Plan constantsVSCode Extension:
packages/vscode-ide-companion/src/services/acpConnection.tspackages/vscode-ide-companion/src/services/qwenAgentManager.tspackages/vscode-ide-companion/src/services/qwenConnectionHandler.tspackages/vscode-ide-companion/src/types/acpTypes.tspackages/vscode-ide-companion/src/utils/authErrors.tspackages/vscode-ide-companion/src/webview/App.tsxpackages/vscode-ide-companion/src/webview/components/layout/Onboarding.tsxpackages/vscode-ide-companion/src/webview/handlers/AuthMessageHandler.tspackages/vscode-ide-companion/src/webview/handlers/MessageRouter.tspackages/vscode-ide-companion/src/webview/handlers/SessionMessageHandler.tspackages/vscode-ide-companion/src/webview/hooks/useWebViewMessages.tspackages/vscode-ide-companion/src/webview/providers/MessageHandler.tspackages/vscode-ide-companion/src/webview/providers/WebViewProvider.tsWebUI:
packages/webui/src/components/layout/Onboarding.tsx- Complete UI overhaulpackages/webui/src/utils/i18n.ts- New i18n moduleTechnical Details
Authentication Flow
_metaparameter to authenticate handlerType Safety Notes
Some
anytypes were introduced to handle dynamic authentication metadata passing between components. These should be refined in future iterations with proper interface definitions.Testing
Related Issues
Screenshots
Video
vscc1.mp4