Try to use the model specified in --model even with OpenAI#25
Open
BingqingLyu wants to merge 1 commit into
Open
Try to use the model specified in --model even with OpenAI#25BingqingLyu wants to merge 1 commit into
BingqingLyu wants to merge 1 commit into
Conversation
This was referenced Apr 28, 2026
Owner
Author
Conflict Group 1This PR shares modified functions with 2 other PR(s): #10, #30. These PRs should be reviewed as a batch — merging one may affect the others.
graph LR
PR25["PR #25"]
FgetSeedSource_5386["getSeedSource<br>contentGenerator.ts"]
PR25 -->|modifies| FgetSeedSource_5386
PR30["PR #30"]
PR30 -->|modifies| FgetSeedSource_5386
FsetSource_5386["setSource<br>contentGenerator.ts"]
PR25 -->|modifies| FsetSource_5386
PR10["PR #10"]
PR10 -->|modifies| FsetSource_5386
PR30 -->|modifies| FsetSource_5386
Posted by codegraph-ai conflict detection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
When specifying an openai-base-url and an openai-api-key via CLI args, the CLI silently falls back to the default model, regardless of what model is specified using --model. This is fixed here, by using --model.
Dive Deeper
Appearently, it is possible to specify all OpenAI API parameters using Environment variables, but this is undocumented. --help shows that --openai-api-key and --openai-base-url are supported as CLI parameters. Thus it would seem natural that the model is specified via --model. It turns out that it is entirely impossible to specify the model used when specifying openai-api-key etc and instead the code tries to infer the model from environment variables (
OPENAI_MODEL) or falls back to the default model.Another way to fix this would be to not provide a path through the CLI arguments to control OpenAI API usage but only through environment variables, and to adequately document this option.
Reviewer Test Plan
Check that the following command works after the change
Testing Matrix
Linked issues / bugs