fix: return the concat content for array type of function response.#24
Open
BingqingLyu wants to merge 1 commit into
Open
fix: return the concat content for array type of function response.#24BingqingLyu wants to merge 1 commit into
BingqingLyu wants to merge 1 commit into
Conversation
The functionResponse should contain the content of the function response, not the generic message for default/unhandled case. This change fixes commonly used tools like ReadManyFiles, making them correctly return the file contents to LLM.
Owner
Author
Conflict Group 1This PR shares modified functions with 1 other PR(s): #96. These PRs should be reviewed as a batch — merging one may affect the others.
graph LR
PR24["PR #24"]
FtoParts_1638["toParts<br>coreToolScheduler.ts"]
PR24 -->|modifies| FtoParts_1638
PR96["PR #96"]
PR96 -->|modifies| FtoParts_1638
Posted by codegraph-ai conflict detection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionResponse should contain the content of the function response, not the generic message for default/unhandled case.
This change fixes commonly used tools like ReadManyFiles, making them correctly return the file contents to LLM.
TLDR
This change fixes commonly used tools like ReadManyFiles, making them correctly return the file contents to LLM.
Reviewer Test Plan
The difference before/after the change can be directly verified by
Testing Matrix