TLDR

This PR resolves Issue QwenLM#319 by fixing path handling issues when accessing files across multiple workspace directories. The fix prevents application crashes when users include external directories in their includeDirectories settings or add directories dynamically (via /directory add path/to/directory) and also resolves the "I couldn't fully process the contents of /path/to/directory due to path formatting issue" error, enabling robust multi-directory workspace support.

Dive Deeper

Problem Analysis - The Error Scenario:

User Configuration in settings.json:

{
  "includeDirectories": [
    "F:/qwencode/qwen-code",
    "E:/filefolder"
  ]
}

Or If You Are In Window, this could be:

{
  "includeDirectories": [
    "F:\\qwencode\\qwen-code",
    "E:\\filefolder"
  ]
}

Or Adding Directory via Command:

/directory add E:/filefolder

User Prompt:

> What's inside E:/filefolder

Result - Application Crashed with Error:

Error: path should be a path.relative()d string
    at async Promise.all (index 1)
    at async GeminiClient.getEnvironment
    (file:///F:/qwencode/qwen-code/packages/core/dist/src/core/client.js:152:34)

Or Partial Processing Error:

I couldn't fully process the contents of E:/filefolder due to path formatting issue

Root Cause Analysis:

1. FileDiscoveryService was only initialized with the main target directory (F:/qwencode/qwen-code)
2. When user asked about E:/filefolder, the system tried to calculate relative paths from the main directory
3. path.relative('F:/qwencode/qwen-code', 'E:/filefolder') generated invalid paths like ../../E:/filefolder
4. The ignore file validation failed because it expected relative paths within the project root
5. Promise.all crashed when any directory access failed, bringing down the entire application

Solution Implementation:

Same User Configuration & Prompt - Now Working:

✔ ReadFolder E:/filefolder

Listed 3 item(s).

The contents of E:/filefolder are:
- A directory named myfolder  
- Two files: computer.txt and test.txt

Technical Fixes Applied:

1. Enhanced FileDiscoveryService: Now properly handles multiple workspace directories
2. Smart Path Resolution: LSTool.execute() finds the appropriate workspace directory for each path
3. Graceful Error Handling: Promise.allSettled replaces Promise.all, preventing crashes
4. Skip External Validation: Ignore file validation is skipped for external directories
5. Robust Directory Processing: Each directory is processed independently with proper error recovery

Key Changes Made:

1. Fixed FileDiscoveryService initialization to use primary workspace directory
2. Enhanced LSTool.execute() to properly calculate relative paths for files in multiple workspace directories
3. Added skip logic for ignore file validation for external workspace directories to prevent path.relative() validation errors
4. Replaced Promise.all with Promise.allSettled in getEnvironment() and getDirectoryContext() methods
5. Added comprehensive error handling for ignore file checking operations

Reviewer Test Plan

To validate this fix works correctly:

1. Setup Test Environment:

   • Create a settings.json with multiple directories in includeDirectories
   • Include at least one external directory (outside main project)

2. Test the Fix:

   • Start the CLI: npm start
   • Try accessing external directory: "What's inside <external_directory>"
   • Verify it lists contents without crashing

3. Test Edge Cases:

   • Try with non-existent directories
   • Test with directories that have permission issues
   • Verify main project directory still works normally

4. Regression Testing:

   • Test single directory workspaces still work
   • Verify ignore files (.gitignore, .geminiignore) still function properly within main project

Testing Matrix

Linked issues / bugs

Fixes QwenLM#319