fix(win32): runner.cmd wrapped in double quotes to prevent spawn err#849
Open
BingqingLyu wants to merge 6 commits intomainfrom
Open
fix(win32): runner.cmd wrapped in double quotes to prevent spawn err#849BingqingLyu wants to merge 6 commits intomainfrom
BingqingLyu wants to merge 6 commits intomainfrom
Conversation
Fixes openclaw#45275 **Problem** runner.cmd which contained spaces in the path was being passed as is to the spawn function. node documentation states that paths with spaces must be wrapped with quotes before being passed to the spawn function. **Solution** wrapped the path in double quotes for windows platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes openclaw#45275
Problem
runner.cmd which contained spaces in the path was being passed as is to the spawn function. node documentation states that paths with spaces must be wrapped with quotes before being passed to the spawn function.
Solution
wrapped the path in double quotes for windows platform.
Change type: bug fix