fix: correct Windows Chrome executable path extraction regex#834
Open
BingqingLyu wants to merge 1 commit intomainfrom
Open
fix: correct Windows Chrome executable path extraction regex#834BingqingLyu wants to merge 1 commit intomainfrom
BingqingLyu wants to merge 1 commit intomainfrom
Conversation
Fixes broken Chrome user profile attach on Windows by correcting invalid regex patterns in extractWindowsExecutablePath: - Removed extra backslash before .exe in quoted path regex that was preventing matches - Fixed unquoted path regex to properly handle Windows paths with backslashes - Updated regex patterns to match all valid Windows executable paths ending with .exe Fixes openclaw#48043
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Chrome user profile attach functionality on Windows by correcting invalid regex patterns in
extractWindowsExecutablePath:.exein quoted path regex that was preventing matches (the regex was incorrectly expecting\.exeinstead of just.exeat the end of the path)[^\\s]+pattern with\S+to match all non-whitespace characters including backslashes)Changes
src/browser/chrome.executables.ts: updated the two regex patterns in theextractWindowsExecutablePathfunctionTesting
Verified fix with test cases for both quoted and unquoted Windows paths, including paths with spaces, special characters, and different executable locations. All test cases now correctly extract the executable path.
Fixes openclaw#48043