fix(exec): skip heartbeat wake for subagent sessions#2514
Open
BingqingLyu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip
requestHeartbeatNowfor subagent session keys in bothmaybeNotifyOnExit()andemitExecSystemEvent(). Subagent sessions receive exec results via process poll and report completion viasubagent_announce, so the exec-event heartbeat wake is redundant and wasteful.Problem
Each background exec completion in a subagent triggers
requestHeartbeatNow({reason: "exec-event"}). SinceresolveHeartbeatSessionfalls back subagent keys to the main session, this causes spurious heartbeat wake-ups (and LLM calls) on the parent agent every time a subagent exec finishes.In a session with 47 subagent exec calls, this produced ~50 unnecessary LLM invocations.
Changes
requestHeartbeatNowcall sites withisSubagentSessionKey(sessionKey)isSubagentSessionKeyfromsession-key-utils.jsTesting
emitExecSystemEventwith subagent session key →requestHeartbeatNownot called (butenqueueSystemEventstill fires)Fixes openclaw#66748