fix: redact secrets in /config show replies#2399
Open
BingqingLyu wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Summary
/config showexposed the raw parsed config object directly in chat replies, so owner-triggered config inspection could leak gateway tokens, provider API keys, and channel secrets into message history. This patch routes both full-config and path-specific/config showresponses through the existing schema-aware config redaction pipeline before rendering the JSON reply.Issue Linkage
Fixes openclaw#65623
Security Snapshot
Implementation Details
Files Changed
src/auto-reply/reply/commands-config.ts(+6/-2)src/auto-reply/reply/commands-gating.test.ts(+62/-0)Technical Analysis
The vulnerable
/config showpath inhandleConfigCommandclonedsnapshot.parsedand serialized it directly into the chat response. The fix now loads runtime schema UI hints and appliesredactConfigObject(...)before either subtree lookup or full-object rendering, so the chat-command path matches the existing redaction guarantees already used byconfig.get.Validation Evidence
pnpm test src/auto-reply/reply/commands-gating.test.tsRisk and Compatibility
AI-Assisted Disclosure