fix(slack): preserve thread context for Agents & Assistants DM root messages#2228
Open
BingqingLyu wants to merge 3 commits into
Open
fix(slack): preserve thread context for Agents & Assistants DM root messages#2228BingqingLyu wants to merge 3 commits into
BingqingLyu wants to merge 3 commits into
Conversation
Add missing "context_window_exceeded" (underscore variant) pattern to the mockedIsLikelyContextOverflowError stub in the test harness. The real isLikelyContextOverflowError delegates to isContextOverflowError which matches "context_window_exceeded", but the mock only checked "context window exceeded" (spaces). This caused the new stopReason-based context overflow test to always fail because the mock returned false for "model_context_window_exceeded". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous fix unconditionally set messageThreadId when hasThreadTs was true, which affected channel/group messages where thread_ts == ts (auto- created top-level threads). This caused buildSlackThreadingToolContext to force replyToMode to "all" in non-DM contexts, unexpectedly routing tool and subagent outputs into threads. Now the override only applies when channel_type is "im", correctly limiting it to the Slack Agents & Assistants DM root-message scenario. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves thread context for Agents & Assistants DM root messages in Slack integration.
Closes openclaw#63659
Testing