fix(acpx): add windowsHide to MCP proxy spawn on Windows#1945
Open
BingqingLyu wants to merge 4 commits intomainfrom
Open
fix(acpx): add windowsHide to MCP proxy spawn on Windows#1945BingqingLyu wants to merge 4 commits intomainfrom
BingqingLyu wants to merge 4 commits intomainfrom
Conversation
Add .mp3 and audio/mpeg detection in resolveFeishuOutboundMediaKind() so that TTS-generated audio files (typically .mp3) are sent as voice messages instead of file attachments in Feishu. Fixes openclaw#59588
Add a configurable timeout for Ollama API requests to prevent the web chat from hanging indefinitely when using local Ollama. The fix: 1. Adds a default 2-minute timeout (120s) for local Ollama requests as a safety net when no external abort signal is provided. 2. Allows users to configure a custom timeout via the provider config (models.providers.ollama.timeoutSeconds). 3. The timeout is only applied when no external signal is provided, respecting any external abort controller from the agent runtime. This addresses the issue where direct Ollama API calls work normally but OpenClaw web chat hangs indefinitely. The default 120s should be sufficient for local models while still allowing users to tune it via config if needed. Fixes openclaw#60330
Fix TypeScript error where timeout cleanup code referenced 'response' before it was declared. Move the clearTimeout call after the fetch.
On Windows, the MCP proxy spawns the target agent command (e.g., npx codex-acp) without the windowsHide option. This can cause issues where the spawned process exits with code 1 due to terminal window handling issues. This fix adds windowsHide: true to the spawn options when running on Windows, consistent with how the main acpx spawn handles Windows terminals. Fixes openclaw#60672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the MCP proxy spawns the target agent command (e.g., npx codex-acp)
without the windowsHide option. This can cause issues where the spawned process
exits with code 1 due to terminal window handling issues.
This fix adds windowsHide: true to the spawn options when running on Windows,
consistent with how the main acpx spawn handles Windows terminals.
Fixes openclaw#60672