Fix Xiaomi MiMo reasoning-only completions#1914
Open
BingqingLyu wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mimo-v2-pro/mimo-v2-omnican return the user-visible final answer inreasoning_content, which OpenClaw currently surfaces asthinkinginstead of normal assistant text, so the reply can appear blank.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause / Regression History (if applicable)
reasoning_content. The shared parser maps that to athinkingblock, while downstream rendering expects user-visible output intextblocks.git blame, prior PR, issue, or refactor if known): the shared OpenAI-compatible parsing behavior is reasonable for providers that usereasoning_contentfor actual reasoning output, but Xiaomi MiMo uses it for the final visible answer in this case.openai-completionspath without a provider-specific normalization step.Regression Test Plan (if applicable)
extensions/xiaomi/index.test.tsmimo-v2-pro/mimo-v2-omniare normalized into text, while non-target Xiaomi models remain unchanged.wrapStreamFnseam without needing live Xiaomi API traffic.User-visible / Behavior Changes
mimo-v2-pro/mimo-v2-omnireplies no longer appear blank when the provider returns the final answer viareasoning_content.Diagram (if applicable)