fix: use LRU eviction for cron schedule cache instead of FIFO#137
Open
BingqingLyu wants to merge 2 commits into
Open
fix: use LRU eviction for cron schedule cache instead of FIFO#137BingqingLyu wants to merge 2 commits into
BingqingLyu wants to merge 2 commits into
Conversation
On cache hit, delete and re-set the entry to move it to the end of Map iteration order. This prevents frequently-accessed cron expressions (e.g. heartbeat schedules) from being evicted prematurely while rarely-used entries persist. Fixes openclaw#39679 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add hasCronInCacheForTest helper and assert specific cache entries survive or get evicted. The test now fails under FIFO but passes under LRU, directly verifying the promotion behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveCachedCron(), delete and re-set the entry to move it to the end of Map iteration order*/5 * * * *heartbeats) from being evicted prematurelyTest plan
pnpm build && pnpm check && pnpm testall greenFixes openclaw#39679
🤖 Generated with Claude Code