fix(telegram): prioritize topic-level requireMention over activation override#1012
Open
BingqingLyu wants to merge 1 commit intomainfrom
Open
fix(telegram): prioritize topic-level requireMention over activation override#1012BingqingLyu wants to merge 1 commit intomainfrom
BingqingLyu wants to merge 1 commit intomainfrom
Conversation
…override In the requireMention resolution chain, topic-level config was evaluated after activationOverride (from /activate and /deactivate session state), which meant persisted activation state could override explicit per-topic requireMention config. Reorder firstDefined() so topic config always wins. Fixes openclaw#49864 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-topic
requireMentionoverride is ignored in Telegram forum supergroups — group-level setting always wins.Fixes openclaw#49864
Root Cause
In
bot-message-context.ts, therequireMentionresolution chain usedfirstDefined()with this order:activationOverride(persisted from/activateor/deactivatecommands) was evaluated beforetopicConfig?.requireMention, so any persisted activation state would override explicit per-topic config.Fix
Reorder
firstDefined()so topic config is evaluated first:Testing
Added 4 new tests in a dedicated test file:
requireMention=falseoverrides grouprequireMention=trueactivationOverriderequireMentionstill works when no topic configactivationOverridestill works when no topic configAll 4 tests pass.
Made-with: Claude Code (Claude Opus 4.6)