Merged
Conversation
Owner
Author
|
@somebody32 Since you commented on this in #55, I'm curious as to your thoughts here. |
|
Yep, this is totally what I had in mind, many thanks! Component's API will be a lot easier and there will be no need to change mixin after hierarchy change |
|
When will this get merged? |
Contributor
|
Looking forward to this myself as well. |
Owner
Author
|
This is available in v1.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having separate mixins makes refactoring more difficult and requires simulating a
contextin order to test components in isolation. This PR implementsFluxMixinas a mixin that accesses theFluxinstance via props (if it exists) or context (if it doesn't).