Fix border background, list icons, background color of body not working#4
Merged
BigJk merged 1 commit intoBigJk:mainfrom Mar 8, 2026
Merged
Conversation
…s and this should be all.
Owner
|
Sorry for the late reply. It seems I missed the notifications for this repo! I will check this out as soon as I can. Thank you for your time! 😄 |
Owner
|
I tested it. Works like a charm and is a nice improvement over my hacky code! Thanks for your time and I don't mind that it's LLM-Assisted. The artifacts and shortcomings could be addressed in the future, but even with them there is already a lot of cool stuff that can be done with it that weren't easy todo in ImGui layout-wise before. At least for my use-cases this works well enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3 .
It also solves most of the comments left around as TODOs in code.
PS. Border calculations are (and were) a bit off because of the version of litehtml being used not supporting float pixel position but integers. So no 0.5px borders.
It was fixed litehtml/litehtml#415 but it is not yet in a full release.
Also, the public interface of the library has shifted a lot, so it would be a considerable rework to operate with that.
Aside from that, they are not pixel perfect still:
Final disclosure, unlike my other two PRs this one was partially llm-assisted; while I manually tested and fixed some more things on my own, if you are against just feel free to reject it.