Merged
Conversation
d554955 to
fb5be45
Compare
fb5be45 to
4360960
Compare
hstrowd
approved these changes
Feb 26, 2025
Collaborator
hstrowd
left a comment
There was a problem hiding this comment.
I believe this all looks correct to me. There are a lot of changes in here but I gave it as thorough of a review as I could. One minor non-blocking comment.
DLavin23
approved these changes
Feb 26, 2025
Contributor
DLavin23
left a comment
There was a problem hiding this comment.
Double checked locally to see if there are any leftover references, but couldn't find any. Looks great, thanks for getting rid of this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorbet can be a great tool, but not one that we're equipped to support in FeatureMap's current state. This PR removes it.
As far as the single commit goes... sorry.
Note: I did double check bin/featuremap validate, test coverage, and docs generation against Glue and saw no changes to the assignments file or the generated metrics.