fix: do not skip undefined or null properties #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes behavior of `getWherePredicateCondition` and `buildWhere` methods to match the behavior in typeorm 0.2, which is to apply an IsNull() condition to null values and not ignore undefined values so that when passing undefined queries do not return any data (null or []) rather than excluding that condition which is a vector for security issues. Closes: typeorm#9316 BREAKING CHANGE: passing an undefined value in a query will not return any rows, passing null will match with IsNull()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Duplicate change as typeorm#10443 except this is branched off of the commit tied to the latest typeorm release at the time of this PR's creation 0.3.17
Changes behavior of
getWherePredicateConditionandbuildWheremethods to match the behavior in typeorm 0.2, which is to apply an IsNull() condition to null values and not ignore undefined values so that when passing undefined queries do not return any data (null or []) rather than excluding that condition which is a vector for security issues.Closes: typeorm#9316
BREAKING CHANGE: passing an undefined value in a query will not return any rows, passing null will match with IsNull()
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000