Adds support for <1Gi PVCs and implements signal handling#303
Merged
BeryJu merged 4 commits intoBeryJu:mainfrom Oct 11, 2024
Merged
Adds support for <1Gi PVCs and implements signal handling#303BeryJu merged 4 commits intoBeryJu:mainfrom
BeryJu merged 4 commits intoBeryJu:mainfrom
Conversation
A copy timeout flag is added to set a custom value and support for volumes <1G is added. Previously if you had a pvc that was, say, 512Mi, the duration would be calculated as 0 * time.Second. A parent context is created for the root command that will be done on os.Kill and os.Interrupt to make the tool more polite and improve cleanup. It is propagated into BaseStrategy to be used with client-go calls. A few minor improvements to quiet gopls analyses and warnings, moved to an opts struct for strategies.NewBaseStrategy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A copy timeout flag is added to set a custom value and support for
volumes <1G is added. Previously if you had a pvc that was, say, 512Mi,
the duration would be calculated as 0 * time.Second.
A parent context is created for the root command that will be done
on os.Kill and os.Interrupt to make the tool more polite and improve
cleanup. It is propagated into BaseStrategy and Migrator to be used with client-go
calls.
A few minor improvements to quiet gopls analyses and warnings, moved
to an opts struct for strategies.NewBaseStrategy, and fixed spurious io.EOF
warning logs.
Upgrades go and pkg deps.