Fix inability to rename resulting tar on export if /tmp is on another filesystem (tmpfs)#166
Merged
BeryJu merged 2 commits intoBeryJu:mainfrom Feb 26, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the temporary directory is on a different filesystem than the one korb is called from, go's
os.Renamefunction is unable to rename the file, because it would need to be moved (copy actual bytes) between filesystems:The above error was suppressed by not handling it.
This PR avoids using a potential tmpfs, because of it's possible size restrictions and the requirement to move the resulting file, replaces the deprecated
ioutil.TempFilefunction and enabled error handling on renaming.