Implemented TypeComparer For GetOrCreateProperty When There Are More …#91
Merged
ManlyMarco merged 1 commit intoBepInEx:masterfrom Jul 26, 2023
krulci:master
Merged
Implemented TypeComparer For GetOrCreateProperty When There Are More …#91ManlyMarco merged 1 commit intoBepInEx:masterfrom krulci:master
ManlyMarco merged 1 commit intoBepInEx:masterfrom
krulci:master
Conversation
…Than One Matching Elements
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implemented a
TypeComparerforPass80UnstripMethods::GetOrCreateProperty()to resolve the error ofSequence contains more than one matching element.The original logic only compares the property name and parameters count.
There are cases where two properties of the same name and the same number of parameters count, but differ between the parameter type.
Such as in the case of the below screenshot: