Skip to content

Implemented TypeComparer For GetOrCreateProperty When There Are More …#91

Merged
ManlyMarco merged 1 commit intoBepInEx:masterfrom
krulci:master
Jul 26, 2023
Merged

Implemented TypeComparer For GetOrCreateProperty When There Are More …#91
ManlyMarco merged 1 commit intoBepInEx:masterfrom
krulci:master

Conversation

@krulci
Copy link
Copy Markdown
Contributor

@krulci krulci commented May 10, 2023

This pull request implemented a TypeComparer for Pass80UnstripMethods::GetOrCreateProperty() to resolve the error of Sequence contains more than one matching element.
The original logic only compares the property name and parameters count.
There are cases where two properties of the same name and the same number of parameters count, but differ between the parameter type.
Such as in the case of the below screenshot:

{UnityEngine.AnimationClip.UnityEngine.AnimatorOverrideController::Item(System.String)}
{UnityEngine.AnimationClip.UnityEngine.AnimatorOverrideController::Item(UnityEngine.AnimationClip)}

image

Copy link
Copy Markdown
Member

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ManlyMarco ManlyMarco merged commit 441577f into BepInEx:master Jul 26, 2023
@ds5678 ds5678 added this to the 1.4.6 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants