Fix GenericMethod_GetMethod_Hook on Unity 2020.3.41+#89
Merged
Kasuromi merged 1 commit intoBepInEx:masterfrom May 21, 2023
Merged
Fix GenericMethod_GetMethod_Hook on Unity 2020.3.41+#89Kasuromi merged 1 commit intoBepInEx:masterfrom
Kasuromi merged 1 commit intoBepInEx:masterfrom
Conversation
Kasuromi
approved these changes
May 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash after call to
GenericMethod::GetMethod()hook.This issue appears on Unity version 2020.3.41+, and in some cases in 2021.3.12+, 2022.1.23+ because of this fix
In these versions
Object::GetVirtualMethod()callsGenericMethod::GetGenericVirtualMethod()instead ofGenericMethod::GetMethod()This also has an annoying interaction with shims added in 2021.2.0, where they get inlined together.
I also removed
targetTargets.Length == 1check because it seems to be always true, due to early return inGenericMethod::GetMethod()that I noticed. Unfortunately because of this, problems on debug builds could emerge. I don't know if these are important though.Tested on a custom test game built using 2020.3.46.
@decaprime also confirmed no issues on their beta version of the V Rising Unity 2020.3.46
Also tested on CoreKeeper 2021.3.14, no issues there.
For reference some relevant Unity libil2cpp versions are available here: link