Fix crash calling delegate invoke on il2cpp 29 or higher#78
Merged
Kasuromi merged 5 commits intoBepInEx:masterfrom Feb 17, 2023
Merged
Fix crash calling delegate invoke on il2cpp 29 or higher#78Kasuromi merged 5 commits intoBepInEx:masterfrom
Kasuromi merged 5 commits intoBepInEx:masterfrom
Conversation
Kasuromi
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes that calling delegate
Invoke()method caused a crash on il2cpp version 29 or higher.This issue is caused by a new field in the
MethodInfoclass calledvirtualMethodPointer. Now when calling delegates il2cpp uses it to determine what to call. Since Il2CppInterop was not aware of that, it's value was null thus causing the crash.I'm not entirely sure if it's supposed to have a value of it's own though. I have checked with a type from my game and every method there had
virtualMethodPointerfield equal tomethodPointerfield.I have tested this on Unity 2021.3.14, il2cpp 29: no crashes calling delegates or UnityEvent's