Fix invalid return value when calling injected methods via Il2Cpp reflection#74
Merged
Kasuromi merged 1 commit intoBepInEx:masterfrom Feb 14, 2023
Merged
Conversation
Contributor
Author
|
So far I have tested value type and reference types being passed correctly. Not sure about byref ones though. Also probably a test on 27 version of il2cpp would good. |
Kasuromi
approved these changes
Feb 14, 2023
Member
Kasuromi
left a comment
There was a problem hiding this comment.
Behavior remains the same for pre-v29 game versions.
Tested on v24 & two v27 games.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where calling injected methods via Il2Cpp reflection resulted in garbage data for value types and null for reference types returned.
This issue is caused by change in signature of invoker_method in Il2Cpp version 29