Small tweaks to the CreateTypedefs pass#68
Merged
Kasuromi merged 1 commit intoBepInEx:masterfrom Dec 22, 2022
Merged
Conversation
* <PrivateImplementationDetails> should be namespace prefixed * Revised the definition for injected Cpp2IL types
Kasuromi
reviewed
Dec 22, 2022
Member
Kasuromi
left a comment
There was a problem hiding this comment.
What is the reason behind allowing <PrivateImplementationDetails> to be processed by the generator?
Collaborator
Author
It was already allowed. This just un-does the portion of #61 that placed it in the global namespace. |
Member
My mistake, I see that now. |
Kasuromi
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<PrivateImplementationDetails>should be Il2Cpp namespace prefixed.callanalyzerprocessing layer produces types in theCpp2ILInjected.CallAnalysisnamespace.