Get rid of the Thread.Sleep(1) workaround in InjectorHelpers#56
Merged
ghorsington merged 2 commits intoBepInEx:masterfrom Nov 13, 2022
Merged
Conversation
Kasuromi
approved these changes
Nov 11, 2022
Member
Kasuromi
left a comment
There was a problem hiding this comment.
Looks good.
I agree on overlooking this breaking change when pushing the next release (as we've done before), but I'd like to hear what @ghorsington thinks before we do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigns the trampoline before applying the detour so there are never any nulls.
Unfortunately this is a breaking change because we need to add the
GenerateTrampolinetoIDetour, but because afaik BepInEx is the only consumer of that api we could just overlook it?