Cleanup arrays and annotate for nullability#185
Merged
ds5678 merged 10 commits intoBepInEx:masterfrom Oct 5, 2024
Merged
Conversation
js6pak
requested changes
Oct 5, 2024
| public void Dispose() | ||
| { | ||
| myArray = null; | ||
| myArray = null!; |
Member
There was a problem hiding this comment.
Does it even make sense to null it out?
Collaborator
Author
There was a problem hiding this comment.
Not really in my opinion
Collaborator
Author
There was a problem hiding this comment.
But I don't want to change it either
Il2CppInterop.Runtime/InteropTypes/Arrays/Il2CppReferenceArray.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: js6pak <me@6pak.dev>
Co-authored-by: js6pak <me@6pak.dev>
js6pak
approved these changes
Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.