Fix Invalid Generic Parameter Names#154
Merged
ds5678 merged 1 commit intoBepInEx:masterfrom Sep 14, 2024
Merged
Conversation
583fe08 to
7cddab8
Compare
7cddab8 to
847f46e
Compare
js6pak
requested changes
Sep 14, 2024
Member
js6pak
left a comment
There was a problem hiding this comment.
Can't we just do new GenericParameter(oldParameter.Name.FilterInvalidInSourceChars()); directly?
Collaborator
Author
That method allocates a new string, so we only want to use it if we have to. |
js6pak
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #130
Closes #131