Account for type name when renaming properties and methods from the deobf map#113
Merged
js6pak merged 3 commits intoBepInEx:masterfrom Feb 25, 2024
Merged
Account for type name when renaming properties and methods from the deobf map#113js6pak merged 3 commits intoBepInEx:masterfrom
js6pak merged 3 commits intoBepInEx:masterfrom
Conversation
Contributor
Author
Kasuromi
approved these changes
Feb 22, 2024
js6pak
approved these changes
Feb 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that when there are two types in the same namespace that have properties or methods with the same name, trying to rename them will work as intended (like fields).
This change is 'breaking', though considering this issue meant property renaming was completely broken makes me think that nobody will be impacted.Now checking for both