Fix local build & Add github action CI#1
Conversation
There was a problem hiding this comment.
Thank you for the PR, but it looks like it breaks the current workflow and some of the requirements.
- The plugins have to target .Net Framework v3.5 because they are used in games that don't support v4.x dlls
- Build output is no longer present inside a single bin folder and the release script does not work anymore (all plugins have to be placed in separate .zip files with a correct directory structure inside, with the plugin version in the .zip filename, this is because often only one or two plugins are useful in a game, and some might even break it).
- File and assembly versions are not set to the plugin version, which can cause problems with apps managing plugins, and more importantly they make it not possible to see the plugin version by hovering over the dll or checking its properties (this is a requirement to reduce end user confusion and support tickets).
You mentioned not being able to build the project after cloning, I assume it's because the required game dlls are not present in the repository and you didn't copy them into the lib folder. The dlls are not included because we have not decided how to handle these files. This could be easily fixed without any changes to csproj files by using a custom nuget feed that has stripped versions of all of the required dlls like https://github.com/IllusionMods/IllusionLibs/ (it's meant for modding games by a specific publisher but it would work fine, ideally we would use a separate bepinex nuget feed instead).
You can join the BepInEx discord server if you'd like to discuss this https://discord.gg/th9JFAfsvn
|
@ManlyMarco Thanks for ur feedback.
Just downgraded netfx to 3.5 by downgrading Mono.Cecil to 0.10.x.
It actually does, if you look at the build artifacts in my CI result, it produces all-in-one archive and per-plugin archives
Have restored those AssemblyInfo.cs files |
ghorsington
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I added some notes in addition to what @ManlyMarco already said. Some of these should be addressed, while some of these are optional notes. I noted which of these are optional. Please review and either address or comment on my notes. Feel free to ask if you have any questions.
|
@ghorsington I've addressed all ur comments, plz take another look |
The prebuilt DLLs do not work for me, I tried to build it locally but found it does not build out of box, so I made a fix and contribute it back, also add a CI job. I've verified the output DLLs and they all work properly with my local BIE 5.4.12 Let me know your concerns, thanks!
P.S. here is the CI result in my fork