Fix purge regions: nether detection, login check inversion, and scan report#2841
Merged
tastybento merged 1 commit intodevelopfrom Mar 13, 2026
Merged
Conversation
…can report
- isNether/isEnd were computed once at constructor time before IWM had
loaded the addon world config, causing the Nether to always appear
disabled. Now evaluated at the start of findIslands() each run.
- canDeleteIsland() had the recent-login branch returning false ("can
delete") instead of true ("cannot delete"), and used findFirst()
instead of anyMatch() so only the first team member was checked.
- Replace the removeIf filter with an explicit iterator loop that
counts islands blocked by level threshold and purge protection, and
reports how many regions each prevents from being purged.
- Add an immediate "please wait" notice right after the candidate count
is logged, before the multi-second freshness/island check begins.
- Update the bug-documenting test to assert the now-correct behaviour:
an island whose member logged in recently is excluded from purge.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isNether/isEndwere evaluated once at constructor time before IWM had loaded the addon world config, causing the Nether to always appear disabled. Now evaluated at the start offindIslands()each run.canDeleteIsland()had the recent-login branch returningfalse("can delete") instead oftrue("cannot delete"), and usedfindFirst()instead ofanyMatch()so only the first team member was checked — entire teams were not protected.removeIffilter with an explicit iterator loop that counts and reports how many islands are blocked by level threshold vs. purge protection flags.Test plan
./gradlew test --tests "world.bentobox.bentobox.api.commands.admin.purge.AdminPurgeRegionsCommandTest"🤖 Generated with Claude Code