Add automatic update notifications on startup#2834
Merged
tastybento merged 2 commits intodevelopfrom Mar 8, 2026
Merged
Conversation
- Extract fetchRaw() in GitHubWebAPI and add fetchArray() to correctly handle JSON array responses (fixes bug in getContributors()) - Add getLatestTagName() to GitHubRepository using the /tags endpoint - Add isNewerVersion(), checkForUpdates(), and printUpdateBanner() to WebManager; wired into requestGitHubData() behind isCheckBentoBoxUpdates() - LOCAL builds skip the check; colored console banner shown when outdated Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HashMap.computeIfAbsent throws ConcurrentModificationException when the mapping function re-enters the same map (e.g. when loading a class triggers loading another class via the same loader). Switch to ConcurrentHashMap which handles re-entrant computeIfAbsent safely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHubWebAPI.fetchArray()added (extractsfetchRaw()helper); fixesgetContributors()which previously calledfetch(...).getAsJsonArray()butfetch()already callsgetAsJsonObject()internally — this would throw on a real responseGitHubRepository.getLatestTagName()fetches the/tagsendpoint and returns the first tag nameWebManagergainsisNewerVersion(),checkForUpdates(), andprintUpdateBanner(); wired intorequestGitHubData()gated by the pre-existingisCheckBentoBoxUpdates()setting (default: true)Behavior
LOCALbuilds (dev environments)Test plan
GitHubRepositoryTest— 3 tests forgetLatestTagName()(happy path, empty array, API throws)WebManagerTest— 8 tests forisNewerVersion()covering minor/patch/major bumps, snapshot stripping, leadingvstripping./gradlew buildpasses🤖 Generated with Claude Code